Remove session property overrides for Hive staging location #17390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
force-pushed
the
hive/tmp-dir-overrides
branch
from
c65691c to
30db1b7
Compare
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
|
Isn't this part of access control to decide who can do what? |
electrum
approved these changes
May 8, 2023
github-actions
bot
added
delta-lake
alexjo2144
force-pushed
the
hive/tmp-dir-overrides
branch
from
30db1b7 to
6cf120a
Compare
raunaqmorarka
approved these changes
May 9, 2023
plugin/trino-hive-hadoop2/src/test/java/io/trino/plugin/hive/TestHiveAlluxioMetastore.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 9, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeModule.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 9, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveLocationService.java
Outdated
Show resolved
Hide resolved
|
generally lgtm % excluded test #17390 (comment) and a test failure |
alexjo2144
force-pushed
the
hive/tmp-dir-overrides
branch
2 times, most recently
from
a900498 to
e13bdcc
Compare
|
Rebased and applied comments. Thanks all. |
findepi
reviewed
May 10, 2023
plugin/trino-hive-hadoop2/src/test/java/io/trino/plugin/hive/s3select/S3SelectTestHelper.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
Users should not have the ability to write files into arbitary locations.
alexjo2144
force-pushed
the
hive/tmp-dir-overrides
branch
from
e13bdcc to
c56cdc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users should not have the ability to write files into arbitary locations.
Additional context and related issues
Extracted first commit into #17389
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: