Fix serialization regression for varbinary map keys #24226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Nov 22, 2024
| @@ -368,8 +369,13 @@ public void encode(JsonGenerator generator, ConnectorSession session, Block bloc | |||
| generator.writeStartObject(); | |||
| for (int i = 0; i < map.getSize(); i++) { | |||
| // Field name is always written as String for backward compatibility, | |||
| // only value is properly encoded. | |||
| generator.writeFieldName(mapType.getKeyType().getObjectValue(session, keyBlock, offset + i).toString()); | |||
| // (except for VarbinaryType where we encode it as Base64 representation of its bytes) | |||
There was a problem hiding this comment.
nit: key/value (not field name/value) would be better nomenclature
There was a problem hiding this comment.
it's called field name in jackson, hence the name
losipiuk
approved these changes
Nov 22, 2024
wendigo
force-pushed
the
serafin/varbinary-map
branch
from
bbe3021 to
818cd05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: