Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aplhabetize additional IDE configurations on docs #24438

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

sthandassery
Copy link
Contributor

@sthandassery sthandassery commented Dec 10, 2024

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link

cla-bot bot commented Dec 10, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sandeep Thandassery.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@sthandassery sthandassery force-pushed the alphabetize-ide-config-instr branch from 8d5dcc0 to 755d9c4 Compare December 10, 2024 18:39
Copy link

cla-bot bot commented Dec 10, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sandeep Thandassery.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ebyhr
Copy link
Member

ebyhr commented Dec 10, 2024

@sthandassery Thanks for fixing this. Did you submit CLA? Also, could you confirm CLA bot message?

@sthandassery
Copy link
Contributor Author

@ebyhr I sent the signed CLA couple of days back and another one today. still waiting on it to be accepted.

@sthandassery sthandassery force-pushed the alphabetize-ide-config-instr branch from 755d9c4 to ecfc372 Compare December 12, 2024 22:09
Copy link

cla-bot bot commented Dec 12, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr marked this pull request as ready for review January 7, 2025 23:28
@ebyhr
Copy link
Member

ebyhr commented Jan 7, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 7, 2025
Copy link

cla-bot bot commented Jan 7, 2025

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr merged commit c69ae21 into trinodb:master Jan 7, 2025
2 checks passed
@github-actions github-actions bot added this to the 469 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants