Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about views in memory only #24607

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Add info about views in memory only #24607

merged 1 commit into from
Jan 2, 2025

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 1, 2025

Description

For the Faker connector.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 1, 2025
@github-actions github-actions bot added the docs label Jan 1, 2025
ebyhr
ebyhr approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could mention that this change is for Faker documentation in PR & commit title instead of the description.

@mosabua
Copy link
Member Author

mosabua commented Jan 2, 2025

You could mention that this change is for Faker documentation in PR & commit title instead of the description.

Done

@mosabua mosabua merged commit 0c056c7 into trinodb:master Jan 2, 2025
2 checks passed
@mosabua mosabua deleted the fakerdocs branch January 2, 2025 02:11
@github-actions github-actions bot added this to the 469 milestone Jan 2, 2025
@mosabua mosabua mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nineinchnick nineinchnick nineinchnick approved these changes

@ebyhr ebyhr ebyhr approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
469
Development

Successfully merging this pull request may close these issues.
4 participants
@mosabua @nineinchnick @raunaqmorarka @ebyhr