Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcs.endpoint property name in docs #24653

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 8, 2025

Description

Silly cut and paste typo we missed in review.

Additional context and related issues

#24645

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 8, 2025
@github-actions github-actions bot added the docs label Jan 8, 2025
@mosabua mosabua requested a review from wendigo January 8, 2025 15:44
@@ -24,9 +24,10 @@ Storage file system support:
all other properties.
* - `gcs.project-id`
- Identifier for the project on Google Cloud Storage.
* - `azure.endpoint`
* - `gcs.endpoint`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah .. silly me

@mosabua mosabua merged commit 328d036 into trinodb:master Jan 8, 2025
4 of 8 checks passed
@mosabua mosabua deleted the gcsend2 branch January 8, 2025 15:48
@github-actions github-actions bot added this to the 469 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants