Grant privileges only on TPCH tables in Redshift query runner #24669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Granting privileges on all tables may cause unintended failures, as temporary tables created in one test class may not have been fully dropped or cleaned up from internal Redshift tables while other test class executes grant privileges on all tables.
mayankvadariya
commented
Jan 9, 2025
| @@ -125,8 +125,9 @@ public DistributedQueryRunner build() | |||
| provisionTables(runner, initialTables); | |||
|
|
|||
| // This step is necessary for product tests | |||
| executeInRedshiftWithRetry(format("GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA %s TO %s", TEST_SCHEMA, GRANTED_USER)); | |||
|
|
|||
| for (TpchTable<?> table : initialTables) { | |||
There was a problem hiding this comment.
// This step is necessary for product tests
By the way is there a Redshift product tests? I don't see them in https://github.com/trinodb/trino/actions/runs/12627786329/job/35182951110
|
/test-with-secrets sha=e19312d66a0dcae1d9e9d341d2d6c5c97c7c4218 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/12700021614 |
ebyhr
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Granting privileges on all tables may cause unintended failures, as temporary tables created in one test class may not have been fully dropped or cleaned up from internal Redshift tables while other test class executes grant privileges on all tables.
Description
Closes #24631
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.