Decode JSONs directly from Slice #24727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
3 tasks
losipiuk
approved these changes
Jan 16, 2025
wendigo
force-pushed
the
serafin/json-slice-input
branch
2 times, most recently
from
c91a44e to
061e819
Compare
wendigo
force-pushed
the
serafin/json-slice-input
branch
from
061e819 to
3fea652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids materialization that happens today:
Slice -> copy bytes -> UTF-8 String/UTF-8 byte[] -> JsonCodec.fromJson
Instead we can just do JsonCodec.fromJson(Slice.getInput()) which doesn't copy bytes from Slice
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: