Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details about numeric and varbinary literals #24774

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

brunokim
Copy link
Contributor

@brunokim brunokim commented Jan 23, 2025

Description

Refine documentation on accepted literal data types

  • Add that consecutive underscores in numbers (e.g., 12__34) is not permitted
  • Add that binary literals allow any number of whitespace characters

Additional context and related issues

#23682

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 23, 2025
@github-actions github-actions bot added the docs label Jan 23, 2025
@brunokim brunokim changed the title More details about literals Add more details about integer and varbinary literals Jan 23, 2025
@brunokim brunokim changed the title Add more details about integer and varbinary literals Add more details about numeric and varbinary literals Jan 23, 2025
@wendigo wendigo requested a review from mosabua January 23, 2025 07:06
@mosabua
Copy link
Member

mosabua commented Jan 23, 2025

Thank you @brunokim .. I tested this all out and it looks good.

@mosabua mosabua merged commit a54bd33 into trinodb:master Jan 23, 2025
8 checks passed
@github-actions github-actions bot added this to the 469 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants