Make configuration and session property names consistent #24781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Jan 23, 2025
core/trino-main/src/main/java/io/trino/server/protocol/spooling/SpoolingConfig.java
Outdated
Show resolved
Hide resolved
It makes it easier to reason about which session property maps to which configuration property.
wendigo
force-pushed
the
serafin/rename-props
branch
from
dce1c7e to
3ffac5f
Compare
|
cc @mosabua |
losipiuk
approved these changes
Jan 23, 2025
|
Will update docs PR after this is merged.. |
|
@mosabua here you go! |
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it easier to reason about which session property maps to which configuration property.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: