Remove flaky assertions in DF test #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
reviewed
Sep 16, 2020
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveDynamicPartitionPruning.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
flaky_df_test
branch
from
9c350e1 to
378ddaa
Compare
sopel39
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
lgtm % modulo @Praveen2112 comment. Let's remove these lines with TODO that points to commit
presto-testing/src/main/java/io/prestosql/testing/AbstractTestQueryFramework.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
flaky_df_test
branch
2 times, most recently
from
135b15d to
66b2869
Compare
raunaqmorarka
changed the title
raunaqmorarka
force-pushed
the
flaky_df_test
branch
from
66b2869 to
a9a9008
Compare
sopel39
reviewed
Sep 16, 2020
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveDynamicPartitionPruning.java
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
flaky_df_test
branch
from
a9a9008 to
5a9fe02
Compare
Praveen2112
approved these changes
Sep 16, 2020
findepi
reviewed
Oct 20, 2021
| assertEquals(probeStats.getInputPositions(), 0L); | ||
| assertEquals(probeStats.getDynamicFilterSplitsProcessed(), 0L); | ||
| // TODO bring back OperatorStats assertions from https://github.com/prestosql/presto/commit/1feaa0f928a02f577c8ac9ef6cc0c8ec2008a46d | ||
| // after https://github.com/prestosql/presto/issues/5120 is fixed |
There was a problem hiding this comment.
@raunaqmorarka would you like to re-enable this?
(or at least re-link to #5172?)
#5120 is closed. #5172 isn't solved, but we have developed ways to deal with that in tests
There was a problem hiding this comment.
I am indeed planning on bringing this back using the assertQueryStats thing we added recently. But I wanted to wait for the in-progress iceberg DF PR to merge which has changes in these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5120