Reconstruct NOT IN when pushing down to JDBC source #6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
approved these changes
Dec 15, 2020
kokosing
approved these changes
Dec 15, 2020
| "AND ((\"col_7\" >= ? AND \"col_7\" < ?) OR (\"col_7\" >= ? AND \"col_7\" < ?)) " + | ||
| "AND ((\"col_8\" >= ? AND \"col_8\" < ?) OR (\"col_8\" >= ? AND \"col_8\" <= ?)) " + | ||
| "AND ((\"col_9\" < ?) OR \"col_9\" IN (?,?)) " + | ||
| "AND (\"col_2\" = ?)"); |
There was a problem hiding this comment.
I don't like this assertion it is very detailed and so it it will be fragile to changes
There was a problem hiding this comment.
It is required to visualize the changes and this is the only place where we test queries output to remote system.
Also, the structure of output queries changes very very rarely, so expected maint cost is low.
| @@ -31,10 +33,13 @@ private Utils() {} | |||
| // just for this use case. | |||
| static final TypeOperators TUPLE_DOMAIN_TYPE_OPERATORS = new TypeOperators(); | |||
|
|
|||
| public static Block nativeValueToBlock(Type type, Object object) | |||
| public static Block nativeValueToBlock(Type type, @Nullable Object object) | |||
| @@ -290,8 +290,8 @@ public void testBuildSqlWithDomainComplement() | |||
| assertThat(lastQuery).isEqualTo("" + | |||
There was a problem hiding this comment.
Do we have query in ATDQ to trigger this pushdown?
There was a problem hiding this comment.
|
AC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6075