Document set digest functions #8269
Conversation
findinpath
force-pushed
the
docs/setdigest-functions
branch
3 times, most recently
from
850c7e1 to
4bd3226
Compare
| The following example showcases how the Set Digest functions are | ||
| employed to estimate the similarity between texts:: | ||
|
|
||
| WITH text_input(id, text) AS (VALUES |
There was a problem hiding this comment.
This query depends on the changes from the PR #8295
Once the PR is accepted, also the documentation of make_set_digest function needs to be correspondingly adjusted.
There was a problem hiding this comment.
@findinpath Just wanted to confirm if the changes to documentation you are talking about are done already?
findinpath
force-pushed
the
docs/setdigest-functions
branch
from
4bd3226 to
3afb353
Compare
| jaccard_index(digest1, digest2) AS jaccard_index | ||
| FROM setdigest_side_by_side | ||
| ORDER BY id1, id2; | ||
|
|
There was a problem hiding this comment.
What would be an appropriate sentence in this context?
Are you implying that the reader may think that the two code blocks are not related?
There was a problem hiding this comment.
It should be a full sentence. E.g.
The query produces the following results:
findinpath
force-pushed
the
docs/setdigest-functions
branch
6 times, most recently
from
534699f to
6caba17
Compare
findinpath
force-pushed
the
docs/setdigest-functions
branch
from
6caba17 to
d4bea30
Compare
| jaccard_index(digest1, digest2) AS jaccard_index | ||
| FROM setdigest_side_by_side | ||
| ORDER BY id1, id2; | ||
|
|
There was a problem hiding this comment.
It should be a full sentence. E.g.
The query produces the following results:
findinpath
force-pushed
the
docs/setdigest-functions
branch
from
d4bea30 to
32a1ed6
Compare
findinpath
force-pushed
the
docs/setdigest-functions
branch
2 times, most recently
from
3e39273 to
26bdb38
Compare
|
Could you look and merge @hashhar ? |
| The following example showcases how the Set Digest functions are | ||
| employed to estimate the similarity between texts:: | ||
|
|
||
| WITH text_input(id, text) AS (VALUES |
There was a problem hiding this comment.
@findinpath Just wanted to confirm if the changes to documentation you are talking about are done already?
|
yes, the showcased functionality is already fully implemented in Trino. |
findinpath
force-pushed
the
docs/setdigest-functions
branch
from
26bdb38 to
b9fc92d
Compare
|
Thank you! This is brilliant documentation. |
This PR adresses the documentation of hash_counts function #7659 and the documentation of setdigest functions #8269
It also provides documentation on how to deal with Set Digest Trino functions which deal with the MinHash technique (used to estimate similarity between two sets).