Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic parameters in make_set_digest function #8295

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Add support for generic parameters in make_set_digest function #8295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions core/trino-main/src/main/java/io/trino/type/setdigest/BuildSetDigestAggregation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@

package io.trino.type.setdigest;

import io.airlift.slice.Slice;
import io.trino.spi.block.BlockBuilder;
import io.trino.spi.function.AggregationFunction;
import io.trino.spi.function.AggregationState;
import io.trino.spi.function.CombineFunction;
import io.trino.spi.function.InputFunction;
import io.trino.spi.function.OutputFunction;
import io.trino.spi.function.SqlType;
import io.trino.spi.type.StandardTypes;
import io.trino.spi.function.TypeParameter;

@AggregationFunction("make_set_digest")
public final class BuildSetDigestAggregation
Expand All @@ -30,7 +32,18 @@ public final class BuildSetDigestAggregation
private BuildSetDigestAggregation() {}

@InputFunction
public static void input(SetDigestState state, @SqlType(StandardTypes.BIGINT) long value)
@TypeParameter("T")
public static void input(@AggregationState SetDigestState state, @SqlType("T") long value)
{
if (state.getDigest() == null) {
state.setDigest(new SetDigest());
}
state.getDigest().add(value);
}

@InputFunction
@TypeParameter("T")
public static void input(@AggregationState SetDigestState state, @SqlType("T") Slice value)
{
if (state.getDigest() == null) {
state.setDigest(new SetDigest());
Expand Down
20 changes: 19 additions & 1 deletion core/trino-main/src/test/java/io/trino/sql/query/TestSetDigestFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,32 @@ public void teardown()
}

@Test
public void testCardinality()
public void testCardinalityForBigintSetDigest()
{
assertThat(assertions.query(
"SELECT cardinality(make_set_digest(value)) " +
"FROM (VALUES 1, 2, 2, 3, 3, 3, 4, 4, 4, 4, 5) T(value)"))
.matches("VALUES CAST(5 AS BIGINT)");
}

@Test
public void testCardinalityForVarcharSetDigest()
{
assertThat(assertions.query(
"SELECT cardinality(make_set_digest(value)) " +
"FROM (VALUES 'trino', 'sql', 'everything', 'sql', 'trino') T(value)"))
.matches("VALUES CAST(3 AS BIGINT)");
}

@Test
public void testCardinalityForDateSetDigest()
{
assertThat(assertions.query(
"SELECT cardinality(make_set_digest(value)) " +
"FROM (VALUES DATE '2001-08-22', DATE '2001-08-22', DATE '2001-08-23') T(value)"))
.matches("VALUES CAST(2 AS BIGINT)");
}

@Test
public void testExactIntersectionCardinality()
{
Expand Down