Reduce UI response data size for cluster overview page #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalbu
approved these changes
Sep 3, 2021
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
akshayrai
reviewed
Sep 27, 2021
core/trino-main/src/main/java/io/trino/server/ui/UiQueryResource.java
Outdated
Show resolved
Hide resolved
|
@posulliv we have done something similar internally. Looking forward to have this change merged. Could you update and rebase the pull request! Thanks! |
posulliv
force-pushed
the
prune-ui-response-data
branch
from
99d3238 to
2ce03c0
Compare
findepi
reviewed
Oct 20, 2021
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/UiQueryResource.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/resources/webapp/src/components/QueryList.jsx
Outdated
Show resolved
Hide resolved
Comment on lines
126
to
128
| if (query.principal) { | ||
| user = ( | ||
| <span>{query.session.user}<span className="glyphicon glyphicon-lock-inverse" style={GLYPHICON_DEFAULT}/></span> | ||
| <span>{query.user}<span className="glyphicon glyphicon-lock-inverse" style={GLYPHICON_DEFAULT}/></span> |
There was a problem hiding this comment.
pre-existing, but why we have condition on principal if we output user field only?
seems like condition should be on user and then principal field could be removed from the response.
@raghavsethi do you remember?
@dedep @aalbu do you know?
posulliv
force-pushed
the
prune-ui-response-data
branch
from
9a7bb3e to
ff58c92
Compare
|
@findepi thank you for the many comments! I updated based on your review. |
posulliv
force-pushed
the
prune-ui-response-data
branch
from
ff58c92 to
bd881e3
Compare
findepi
approved these changes
Oct 22, 2021
core/trino-main/src/main/java/io/trino/server/ui/TrimmedBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/TrimmedBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/ui/TrimmedBasicQueryInfo.java
Outdated
Show resolved
Hide resolved
posulliv
force-pushed
the
prune-ui-response-data
branch
from
bd881e3 to
f7f069b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5929