Add config option to skip setting permissions for new directories #9539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Oct 7, 2021
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HdfsConfig.java
Outdated
Show resolved
Hide resolved
posulliv
force-pushed
the
skip-setting-hdfs-dir-perms
branch
from
734f61b to
42a4100
Compare
kokosing
reviewed
Oct 12, 2021
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HdfsEnvironment.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveWriteUtils.java
Outdated
Show resolved
Hide resolved
posulliv
force-pushed
the
skip-setting-hdfs-dir-perms
branch
from
42a4100 to
26cf950
Compare
kokosing
reviewed
Oct 14, 2021
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HdfsEnvironment.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
posulliv
force-pushed
the
skip-setting-hdfs-dir-perms
branch
from
26cf950 to
4f68c5e
Compare
kokosing
reviewed
Oct 20, 2021
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
posulliv
force-pushed
the
skip-setting-hdfs-dir-perms
branch
from
4f68c5e to
eaebd3a
Compare
kokosing
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where file permissions in HDFS are managed by another system such as Sentry, it would be nice to have the option to skip setting permissions for newly created directories.