Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support higher timestamp precision in MemSQL #9725

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 21, 2021

Relates to #5450

DST handling should be fixed later as I left a comment in #9725.

@cla-bot cla-bot bot added the cla-signed label Oct 21, 2021
@ebyhr ebyhr force-pushed the ebi/memsal-timestamp-6 branch 3 times, most recently from 39c8797 to ea34f29 Compare October 21, 2021 07:27
@ebyhr ebyhr force-pushed the ebi/memsal-timestamp-6 branch from ea34f29 to f1202b4 Compare October 26, 2021 01:29
@ebyhr
Copy link
Member Author

ebyhr commented Oct 26, 2021

CI #9768, #9563

@ebyhr ebyhr requested review from wendigo, findepi and hashhar October 26, 2021 03:34
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question - but looks good otherwise.
Looks like MemSQL doesn't make much information available about the precision of timestamp types.

@ebyhr ebyhr force-pushed the ebi/memsal-timestamp-6 branch from f1202b4 to 5fa2e83 Compare October 26, 2021 06:25
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me % comment.

@ebyhr ebyhr force-pushed the ebi/memsal-timestamp-6 branch from 5fa2e83 to 2758998 Compare October 26, 2021 07:01
@ebyhr ebyhr merged commit b88cc93 into master Oct 26, 2021
@ebyhr ebyhr deleted the ebi/memsal-timestamp-6 branch October 26, 2021 09:18
@github-actions github-actions bot added this to the 364 milestone Oct 26, 2021
@ebyhr ebyhr mentioned this pull request Oct 26, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants