Avoid dynamic filter current predicate computation when not used #9867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Nov 5, 2021
| BooleanSupplier partitionMatchSupplier = () -> partitionMatches(partitionColumns, dynamicFilter.getCurrentPredicate(), hivePartition); | ||
| BooleanSupplier partitionMatchSupplier = | ||
| partitionColumns.stream().anyMatch(dynamicFilter.getColumnsCovered()::contains) | ||
| ? () -> true |
There was a problem hiding this comment.
I think this should the the other way around: if there is covering column then use partitionMatches(partitionColumns, dynamicFilter.getCurrentPredicate(), hivePartition)
There was a problem hiding this comment.
of course, you're correct.
this indicates some missing test coverage, since i just nuked a feature, and build is still green.
@raunaqmorarka @sopel39 do you have idea how this could be tested? can you test cover that?
There was a problem hiding this comment.
There is TestHiveDynamicPartitionPruningTest but I guess it's not complete due to #5172
`DynamicFilter.getCurrentPredicate` is not free to call. Do not call it when results wouldn't be used. The edge case, where `getCurrentPredicate()` returns `TupleDomain.none()` is not worth optimizing for. In the future, it can be handled by the engine instead.
findepi
force-pushed
the
findepi/avoid-dynamic-filter-current-predicate-computation-when-not-used-fbb3ac
branch
from
b6ff62d to
a6a9056
Compare
sopel39
approved these changes
Nov 8, 2021
|
@findepi dynamic partition pruning tests land. Do you want to rebase & merge? |
raunaqmorarka
approved these changes
Nov 25, 2021
findepi
deleted the
findepi/avoid-dynamic-filter-current-predicate-computation-when-not-used-fbb3ac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicFilter.getCurrentPredicateis not free to call. Do not call itwhen results wouldn't be used.
The edge case, where
getCurrentPredicate()returnsTupleDomain.none()is not worth optimizing for. In the future, it canbe handled by the engine instead.
cc @losipiuk @alexjo2144