[#B-08892] Redis Cluster adapter implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgiotas
requested review from
dbaltas,
georgeyord,
vaionicle,
spirostz,
dgiotas and
georgioskyr
vaionicle
reviewed
May 3, 2017
| /** | ||
| * Redis object | ||
| * | ||
| * @var mixed redis object |
vaionicle
reviewed
May 3, 2017
| public function getIdsMatchingTags($tags = []) | ||
| { | ||
| $this->_log(self::METHOD_UNSUPPORTED_BY_REDIS_BACKEND); | ||
| return array(); |
vaionicle
reviewed
May 3, 2017
| } | ||
| } | ||
| return $return; | ||
| } |
vaionicle
reviewed
May 3, 2017
| parent::tearDown(); | ||
| $this->_instance = null; | ||
| // We have to wait after a memcached flush | ||
| // sleep(1); |
vaionicle
reviewed
May 3, 2017
| { | ||
| /** | ||
| * | ||
| * @var TP24_Cache_Backend_Rediscluster |
dgiotas
force-pushed
the
mb/redisClusterAdapter
branch
2 times, most recently
from
b0421a7 to
8a71495
Compare
dgiotas
force-pushed
the
mb/redisClusterAdapter
branch
from
8a71495 to
cc6dbe4
Compare
ngiallelis
reviewed
May 23, 2017
| * | ||
| * | ||
| * @param string $id | ||
| * @return integer or boolean |
There was a problem hiding this comment.
Hey @vaionicle you missed this one in your review: @return integer|false
There was a problem hiding this comment.
Sorry @ngiallelis my man, I left something back for you, just to remind you the goodDays
vaionicle
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.