Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore prototype context when escaping embedded contexts #172

Merged
merged 1 commit into from
Jun 1, 2018
Merged

ignore prototype context when escaping embedded contexts #172

merged 1 commit into from
Jun 1, 2018

Conversation

keith-hall
Copy link
Collaborator

this fixes the bug found at #160 (comment), whereby the prototype context was being applied in the context that is escape-ing embedded contexts, and causing it to not pop out as expected.

trishume
trishume approved these changes Jun 1, 2018
View reviewed changes
Copy link
Owner

@trishume trishume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@trishume trishume merged commit 26a61c3 into trishume:master Jun 1, 2018
@keith-hall keith-hall deleted the embed_prototype branch June 1, 2018 13:41
@trishume trishume mentioned this pull request Jun 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishume trishume trishume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith-hall @trishume