Skip to content

Commit

Permalink
[AMD] Re-enable overflow test in test_reduce_layouts (#5233)
Browse files Browse the repository at this point in the history
#5153 fixed
the issue; but we missed enabling one of the disabled
case.
  • Loading branch information
antiagainst authored Nov 22, 2024
1 parent 422e5d3 commit 16ce143
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions python/test/unit/language/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -2666,8 +2666,6 @@ def test_reduce_layouts(M, N, src_layout, axis, epilogue_kind, dtype_str, add_ov
pytest.skip("Skipping because tensor shape is smaller than M(f)maLayout instr_shape")
if is_hip() and isinstance(src_layout, MfmaLayout) and ((M, N) == (128, 128)):
pytest.skip("Skipping test because it runs out of shared memory")
if add_overflow_check is True and is_hip():
pytest.skip("overflow check disabled on HIP while fixing issues")
if reduce_op == "sum" and dtype_str == "float16" and M * N > 1024:
pytest.skip("Skipping sum reduction on float16 due to accuracy issues")

Expand Down

0 comments on commit 16ce143

Please sign in to comment.