Resolved commits by moving comments to TritonOps.td

triton-lang · Nov 12, 2024 · e5a9bd2 · e5a9bd2
1 parent e95e71b
commit e5a9bd2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/triton/Dialect/Triton/IR/TritonOps.td b/include/triton/Dialect/Triton/IR/TritonOps.td
@@ -731,6 +731,9 @@ def TT_ReduceOp: TT_Op<"reduce",
       llvm::SmallVector<RankedTensorType> getInputTypes();
       llvm::SmallVector<Type> getElementTypes();
       unsigned getNumOperands();
+
+      // Returns the CombineOp iff this ReduceOp's region contains only
+      // one CombineOp other than the return, or nullptr if not applicable.
       ::mlir::Operation *getSingleCombiner();
     }];
 }

diff --git a/lib/Dialect/Triton/IR/Ops.cpp b/lib/Dialect/Triton/IR/Ops.cpp
@@ -503,8 +503,6 @@ llvm::SmallVector<Type> ReduceOp::getElementTypes() {
   return getElementTypesImpl(this->getOperands());
 }
 
-// Returns the CombineOp iff this ReduceOp's region contains only
-// one CombineOp other than the return, or nullptr if not applicable.
 ::mlir::Operation *ReduceOp::getSingleCombiner() {
   if (getNumOperands() != 1 || getNumResults() != 1)
     return nullptr;