Enable tests for argmin/max and fix some bugs #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`argmin`/`argmax` is currently only tested in 1d and when we enable the tests for 2d it reveals a few bugs.
peterbell10
commented
Apr 17, 2023
| @@ -137,11 +137,12 @@ class SimplifyReduceCvt : public mlir::RewritePattern { | |||
| op->getLoc(), newTy, newOperands[i]); | |||
| } | |||
|
|
|||
| rewriter.setInsertionPoint(reduce); | |||
There was a problem hiding this comment.
Because we're matching on the convert_layout op, the rewriter inserts directly after that op and potentially before the rest of the arguments are ready.
| auto newReduce = rewriter.create<triton::ReduceOp>( | ||
| op->getLoc(), newOperands, reduce.getAxis()); | ||
| auto &newCombineOp = newReduce.getCombineOp(); | ||
| rewriter.inlineRegionBefore(reduce.getCombineOp(), newCombineOp, | ||
| newCombineOp.end()); | ||
| rewriter.cloneRegionBefore(reduce.getCombineOp(), newCombineOp, |
There was a problem hiding this comment.
Inlining is destructive, so if the rewrite produces an invalid output this would break the original ReduceOp's region.
ptillet
approved these changes
Apr 18, 2023
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
…ton-lang#1537) `argmin`/`argmax` is currently only tested in 1d and when we enable the tests for 2d it reveals a few bugs.
ZzEeKkAa
pushed a commit
to ZzEeKkAa/triton
that referenced
this pull request
Aug 5, 2024
…fset/emitIndices of dot layout. (triton-lang#1537) Support repCluster in emitOffset/emitIndices utilis for dot layout. --------- Signed-off-by: Tiotto, Ettore <[email protected]> Co-authored-by: Tiotto, Ettore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argmin/argmaxis currently only tested in 1d and when we enable the tests for 2d it reveals a few bugs.