Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Update llvm to llvm/llvm-project@c08c6a71cfc5 #4639

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

htyu
Copy link
Collaborator

@htyu htyu commented Sep 3, 2024

Bumping llvm to include a loop unroller fix: https://github.com/llvm/llvm-project/pull/106164/files . This is needed for subsequent loop unroller upstreaming work.

@htyu htyu requested a review from ThomasRaoux September 3, 2024 18:16
@htyu htyu requested a review from ptillet as a code owner September 3, 2024 18:16
@htyu
Copy link
Collaborator Author

htyu commented Sep 3, 2024

It looks like the desired llvm package could not be found during the build. Is there anything I should do to get it generated?

@antiagainst
Copy link
Collaborator

Yes. You need to land a change in llvm-head to trigger building llvm at the desired commit first.

See #4601 for llvm-head and #4625 for main.

@htyu
Copy link
Collaborator Author

htyu commented Sep 3, 2024

Bumping llvm to include a loop unroller fix: https://github.com/llvm/llvm-project/pull/106164/files . This is needed for subsequent loop unroller upstreaming work.

Thanks for the pointers! #4640 created.

@antiagainst
Copy link
Collaborator

antiagainst commented Sep 4, 2024

Actually we identified a perf regression in AMD backend due to some LLVM commits brought in by #4537. Still investigating. There are already some LLVM integration landed after #4537. Would you mind to hold on landing this a bit if possible? Hopefully it won't take long to identify the issue at least.

@htyu
Copy link
Collaborator Author

htyu commented Sep 4, 2024

Actually we identified a perf regression in AMD backend due to some LLVM commits brought in by #4537. Still investigating. There are already some LLVM integration landed after #4537. Would you mind to hold on landing this a bit if possible? Hopefully it won't take long to identify the issue at least.

Sounds good.

@antiagainst
Copy link
Collaborator

We've identified the issue caused by #4537 due to missing target machine we didn't run some passes now when optimizing llvm module. will have a fix up soon to unblock here.

@antiagainst
Copy link
Collaborator

#4655 addressed the regression due to llvm bump. Please feel free to proceed with this one!

@htyu
Copy link
Collaborator Author

htyu commented Sep 6, 2024

#4655 addressed the regression due to llvm bump. Please feel free to proceed with this one!

Thanks for the update!

@htyu htyu merged commit 9414165 into triton-lang:main Sep 6, 2024
7 checks passed
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
…4639)

Bumping llvm to include a loop unroller fix:
https://github.com/llvm/llvm-project/pull/106164/files . This is needed
for subsequent loop unroller upstreaming work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants