Fix coverity issues #4967
Merged
Fix coverity issues #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Oct 22, 2024
| @@ -128,8 +128,8 @@ static void AddPartialReduce(SmallVector<SmallVector<Value>> &srcValues, | |||
| ConversionPatternRewriter &rewriter, | |||
| const TargetInfoBase &targetInfo, | |||
| ScanLoweringHelper &helper, | |||
| SmallVector<Value> smemBases, | |||
| SmallVector<Type> smemTypes, Value warpId, | |||
| const SmallVector<Value> &smemBases, | |||
There was a problem hiding this comment.
Coverity suggests to use std::move(smemBases) when calling this function, but it looks like smemBases (as well as smemTypes) doesn't change inside the function, so I decided to change the signature.
There was a problem hiding this comment.
Can you make them ArrayRef?
There was a problem hiding this comment.
Done, thanks for the review @Jokeren!
anmyachev
commented
Oct 22, 2024
lib/Analysis/AxisInfo.cpp
Outdated
| @@ -895,7 +895,7 @@ class ShLIOpAxisInfoVisitor final : public BinaryOpVisitorImpl<arith::ShLIOp> { | |||
| lhsDivisibility = 1; | |||
| } | |||
| auto numBits = log2Int(lhsDivisibility); | |||
| return multiplyDivisor(lhsDivisibility, 1 << shift); | |||
| return multiplyDivisor(lhsDivisibility, static_cast<int64_t>(1) << shift); | |||
There was a problem hiding this comment.
The context expects an expression of type int64_t for the second argument, so I use static_cast to avoid using 32-bit arithmetic.
Signed-off-by: Anatoly Myachev <[email protected]>
etiotto
pushed a commit
to intel/intel-xpu-backend-for-triton
that referenced
this pull request
Oct 22, 2024
In the upstream: triton-lang/triton#4967 --------- Signed-off-by: Anatoly Myachev <[email protected]>
Jokeren
approved these changes
Oct 22, 2024
Luosuu
pushed a commit
to Luosuu/triton
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Anatoly Myachev <[email protected]>
guacamoleo
pushed a commit
to guacamoleo/triton
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Anatoly Myachev <[email protected]>
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.