[Frontend] Validate minimum TMA block size in the frontend #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current TMA implementation requires the TMA block shape to have a minimum size, which is the swizzle tile size in smem. Add an error message for this in the frontend so users stop running into codegen crashes.
|
Can we throw a CompilationError ? This would make it more autotuner friendly! |
|
Correct me if I'm wrong, but it seems CompilationError is meant to be raised from the context of the AST visitors, since it requires an AST node. I believe the AssertionError will get wrapped into a CompilationError anyways. |
|
Maybe you could add a test that |
peterbell10
reviewed
Jan 16, 2025
peterbell10
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current TMA implementation requires the TMA block shape to have a minimum size, which is the swizzle tile size in smem. Add an error message for this in the frontend so users stop running into codegen crashes.