Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
make obcpp -j 8
: 1m49sninja obcpp -j 8
: 1m12sEverything seems to just work. In like 5 hours from now the obcpp docker image should contain
ninja-build
, because #139 addedninja-build
to the docker container. At that time I will rerun the actions and make sure they still work.Also I accidentally already updated the README to say it uses ninja in #139, so if for some reason we don't end up switching because of unforeseen problems then we should go back and fix that. But we should keep the note about
-j 8
but in the context ofmake
.