Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ninja #140

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Switch to Ninja #140

merged 5 commits into from
Apr 8, 2024

Conversation

Tyler-Lentz
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz commented Apr 6, 2024

Motivation

  • Running with make obcpp -j 8: 1m49s
  • Running with ninja obcpp -j 8: 1m12s

Everything seems to just work. In like 5 hours from now the obcpp docker image should contain ninja-build, because #139 added ninja-build to the docker container. At that time I will rerun the actions and make sure they still work.

Also I accidentally already updated the README to say it uses ninja in #139, so if for some reason we don't end up switching because of unforeseen problems then we should go back and fix that. But we should keep the note about -j 8 but in the context of make.

Copy link
Member

@atar13 atar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds fine on my end

Copy link
Contributor

@Samir-Rashid Samir-Rashid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work soldier. The battlefront against Ninjas has been vanquished after 5 months 2efd9f0.

I will warn you that the hosted runners have 4 cores 16GB RAM (reference). Hopefully more jobs does not exhaust the runner's memory and kill the build. We will see.

@Tyler-Lentz
Copy link
Contributor Author

Tyler-Lentz commented Apr 8, 2024

Great work soldier. The battlefront against Ninjas has been vanquished after 5 months 2efd9f0.

I will warn you that the hosted runners have 4 cores 16GB RAM (reference). Hopefully more jobs does not exhaust the runner's memory and kill the build. We will see.

image

It's a good thing I randomly chose 4 for the action runner (I typed in a random number, I guess I am just prophetic)

@Tyler-Lentz Tyler-Lentz merged commit 3232fbd into main Apr 8, 2024
2 checks passed
@Tyler-Lentz Tyler-Lentz deleted the chore/switch-to-ninja branch April 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants