separate x86, ARM, Jetson Dockerfiles #49
Conversation
We incorrectly assumed that you needed separate Dockerfiles for devcontainers and just running an application. VS Code will ignore whatever files you COPY into the container and just mount the files of the project at /workspaces/project-name. It also doesn't seem to run whatever command is specified with CMD or ENTRYPOINT. Now the devcontainer.json file points to the Dockerfile at the root of the repository. Also, when we have more Dockerfiles for ARM machines or the Jetson, we can have them all be in the root of the project.
There was a problem hiding this comment.
Thank you for researching this change.
But I disagree. This is going to pollute the root with 3 Dockerfiles (x86, arm, Jetson). I think we should keep all files in this folder.
We will also want to add a .env files with variables for all the URLs are using to be shared among the Dockerfiles.
I agree that we shouldn't pollute the root. However I don't like having them in the dev container folder since they're not used just for dev containers. These Dockeriles will define the way we run the application. On the GCS we use the Go standard of putting them in build/package. Unfortunately that won't work since build is taken by cmake. Maybe we can compromise on a docker folder. |
Yeah, perhaps just put them in a Also do we want the x86 one to just be |
I like Dockerfile.x86 to be consistent. We cannot assume that such a proprietary architecture will be the default. |
Since we are planning on having architecture specific Dockerfiles (for ARM, x86 and Jetson ARM + CUDA), it makes sense to give each Dockerfile an extension that indicates its architecture. The Dockerfiles will also be placed in a docker folder to avoid polluting the root directory.
initially was going to have as a cmake custom target, however the host system might not have cmake setup or built the cmake files. now, only make and docker are needed to build and run the containers
There was a problem hiding this comment.
should be put into cmake
atar13
changed the title
Can we revive this PR? The changes look good. Only thing I would recommend is my above comment. I think I have changed my mind, 3 Dockerfiles is fine for now and we can deduplicate code when we get more clarity about the differences. (Make issue for this before merge) |
|
This is next on my todolist once after I get torchvision sorted out since that's blocking people's work. Issue is over here: #42 |
|
Moving work over to #119 since this branch got stale and is missing a lot of recent changes. |
We incorrectly assumed that you needed separate Dockerfiles for devcontainers and just running an application. VS Code will ignore whatever files you COPY into the container and just mount the files of the project at /workspaces/project-name. It also doesn't seem to run whatever command is specified with CMD or ENTRYPOINT.
Now the devcontainer.json file points to the Dockerfile at the root of the repository.
Also, when we have more Dockerfiles for ARM machines or the Jetson, we can have them all be in the root of the project.