-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI on Julia v1.7 #37
CI on Julia v1.7 #37
Conversation
|
As seen in #38 and discussed on Slack, neither option (CBinding.jl or Clang.jl) is perfect right now. Thus, i tried to provide a workaround that let's us still use the pre-generated bindings on Julia v1.7 without problems. Locally, I get (@v1.7) pkg> build P4est
Building MPI ──→ `~/.julia/scratchspaces/44cfe95a-1eb2-52ea-b672-e2afdf69b78f/00488c6fcaf828685c2bc5139bf0afff8c15c982/build.log`
Building P4est → `~/.julia/dev/P4est/deps/build.log`
┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ Pkg.Operations /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Pkg/src/Operations.jl:1488
Precompiling project...
26 dependencies successfully precompiled in 59 seconds (268 already precompiled, 1 skipped during auto due to previous errors)
julia> using Trixi
julia> include(joinpath(pathof(Trixi) |> dirname |> dirname, "test", "test_examples_2d_p4est.jl"))
[...]
Test Summary: | Pass Total
P4estMesh | 74 74
Main.TestExamples2dP4est
julia> include(joinpath(pathof(Trixi) |> dirname |> dirname, "test", "test_examples_3d_p4est.jl"))
[...]
Test Summary: | Pass Total
P4estMesh | 87 87
Main.TestExamples3dP4est This should give us a bit more time to decide which approach to follow in #38. |
It looks like we got it working with pre-generated bindings on Julia v1.7. Shall we merge it and release a new version to be able to test Trixi on Julia v1.7 (beta, rc)? |
Yes, sounds good to me. However, at the moment most Julia v1.7 tests are failing. Shouldn't we fix those first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the currently failing tests are fixed, this LGTM! Thanks!
I added another CI setup to allow tests on Julia v1.7 that will not mark our usual CI as failed. I needed to introduce another GitHub action for this due to limitations of GH actions... |
Not sure I understand what's going on... from the comments and commit messages I got the understanding, that all tests should pass, but they don't. Some of the failed tests seem like they shouldn't work in the first place, since they cannot make use of the pre-generated bindings. Would it make sense to just |
I thought it might be nice to be able to track whether this stuff works (when modifying our general setup). Based on your comment, I removed the additional tests and put everything back in our standard CI run. |
TODO:
Set lower compat bound for Julia to v1.7Merge once Julia v1.7 is releasedCI:
Thus, it looks like we have three options for P4est to use Julia v1.7.
Xref trixi-framework/Trixi.jl#665