Adapt to P4est_jll v2.8 with MPI support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New p4est library requires new bindings, thus the artifacts were adjusted - The build.jl script automatically includes the MPI library provided by MPI.jl when re-generating bindings for P4est_jll - The README was updated accordingly - The tutorial in the README uses a proper MPI communicator now because the previously used function `sc_MPI_Comm` is only defined if p4est is compiled without MPI support - The point above also implies that this is a breaking change, hence the version number was changed as well
sloede
requested changes
Jan 28, 2022
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
ranocha
reviewed
Jan 28, 2022
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
===========================================
+ Coverage 0 100.00% +100.00%
===========================================
Files 0 1 +1
Lines 0 1 +1
===========================================
+ Hits 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@sloede I added a function to check if the underlying p4est library uses MPI (b1021cf) as we discussed in trixi-framework/Trixi.jl#977 (comment). |
sloede
reviewed
Jan 31, 2022
This reverts commit 1434813.
sloede
reviewed
Jan 31, 2022
ranocha
approved these changes
Jan 31, 2022
sloede
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI.jl when re-generating bindings for P4est_jll
the previously used function
sc_MPI_Commis only defined ifp4est is compiled without MPI support
the version number was changed as well
Depends on JuliaPackaging/Yggdrasil#4324 and trixi-framework/P4est_jll_bindings#4.
The pre-generated bindings artifact should be attached to a new release of the P4est_jll_bindings repository after the PR there has been merged, please make sure that the links in the Artifacts.toml files in this PR here match that release after it's been made.