Merge pull request #403 from trln/bugfix-query-truncation-fallback

Bugfix: provide a fallback term cap (20) for basic searches within f…

VERSION

@@ -1 +1 @@
-2.2.10
+2.2.11

lib/trln_argon/argon_search_builder/clause_count.rb

@@ -24,6 +24,11 @@ def clause_count(solr_parameters)
         when 'isbn_issn'
           # 117 + "edismax", "qf", "isbn_issn_qf", "pf", "pf3", "pf2"
           length = 123
+        else
+          # 20 fallback for any other search field, e.g., call_number
+          # Note that call_number may have its own search builder, see:
+          # https://github.com/trln/argon_call_number_search
+          length = 19
         end
 
         truncate_query(solr_parameters, length)

spec/lib/trln_argon/argon_search_builder_spec.rb

@@ -313,6 +313,22 @@
             'One two three four five six seven eight')
         end
       end
+
+      context 'Any other field search: query contains more than 20 terms' do
+        let(:builder_with_params) do
+          search_builder.with(
+            q: '1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 '\
+            '21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40',
+            'search_field' => 'call_number'
+          )
+        end
+
+        it 'truncates query at 20 terms' do
+          expect(solr_parameters[:q]).to eq(\
+            '1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20'
+          )
+        end
+      end
     end
   end
   # rubocop:enable RSpec/NestedGroups