Fix keyboard nav & icons for Chosen fields in Advanced Search. Fixes … #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TD-1402 & TD-1410. - Drops the trln-chosen-rails forked gem altogether; instead just vendors a few files within trln_argon - Uses the transpiled assets from the chosen_v1.8.7.zip build at https://github.com/harvesthq/chosen/releases/tag/v1.8.7 - These assets were transpiled directly by chosen-rails via its `grunt build` task
|
The keyboard navigation bug is unique to our fork and has something to do with the way our Decaffeinate transpiling of Coffeescript into JS differs from what the gem does in its Grunt build pipeline. This PR offers us a simplified approach that fixes the bug and spares us from having to maintain a gem. There's nothing Rails-y left about the gem that our app needs -- we really only need the final compiled JS & CSS assets, plus the icon sprites, all of which can be easily vendored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TD-1402 & TD-1410.
grunt buildtask