Add missing dependency rexml #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tricknotes! Can you please add a version limitation for this? I think "~> 3.1" should be fine. |
rexml has been removed from default gems since Ruby 3.0. https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ To use rexml, it should be added as runtime dependency. https://github.com/troessner/reek/blob/v6.1.4/lib/reek/report/xml_report.rb#L13 Since rexml is depended from rubocop and kramdown that are only development dependencies, all tests are passed on CI.
tricknotes
force-pushed
the
add-missing-dependency-rexml
branch
from
1f1a97e to
c2fa422
Compare
|
@mvz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rexml has been removed from default gems since Ruby 3.0. https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
To use rexml, it should be added as runtime dependency. https://github.com/troessner/reek/blob/v6.1.4/lib/reek/report/xml_report.rb#L13
Since rexml is depended from rubocop and kramdown that are only development dependencies, all tests are passed on CI.