Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.0 and up #1755

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Support Ruby 3.0 and up #1755

merged 3 commits into from
Dec 28, 2023

Conversation

mvz
Copy link
Collaborator

@mvz mvz commented Dec 27, 2023

  • Drop support for Ruby 2.7
  • Build with Rubies 3.0 through 3.3 in CI

@mvz
Copy link
Collaborator Author

mvz commented Dec 27, 2023

WTF!?

irb(main):001> RUBY_VERSION
=> "3.3.0"
irb(main):002> name = "UncommunicativeMethodName"
=> "UncommunicativeMethodName"
irb(main):003> name.split(/ *(?=[A-Z][a-z])/)
=> ["UncommunicativeMethodName"]
irb(main):004> name = "UncommunicativeParameterName"
=> "UncommunicativeParameterName"
irb(main):005> name.split(/ *(?=[A-Z][a-z])/)
=> ["Uncommunicative", "Parameter", "Name"]

@mvz
Copy link
Collaborator Author

mvz commented Dec 27, 2023

Seems related to this: https://bugs.ruby-lang.org/issues/20095

@mvz
Copy link
Collaborator Author

mvz commented Dec 27, 2023

I'm going to open another PR first to fix support for Ruby 3.3. After that, we can decide about Ruby 2.7.

@mvz mvz force-pushed the support-ruby-3-and-up branch from 8ea0877 to c0eddc3 Compare December 28, 2023 14:55
@mvz mvz merged commit 47cf940 into master Dec 28, 2023
6 checks passed
@mvz mvz deleted the support-ruby-3-and-up branch December 28, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants