Rename CodeParser to TreeWalker.
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troessner
force-pushed
the
rename-codeparser-to-treewalker
branch
from
d229e2b to
c499daf
Compare
|
Like discussed in #395 |
|
Busted by RuboCop! |
|
The changes are fine though; I think you only need to rename the file mentioned in |
troessner
force-pushed
the
rename-codeparser-to-treewalker
branch
from
c499daf to
5398926
Compare
troessner
force-pushed
the
rename-codeparser-to-treewalker
branch
from
5398926 to
a426e47
Compare
|
Fixed!.:) |
|
The changes also look good to me; should I merge in such cases? Also, what’s the Reek release policy? I’d very much welcome 2.0.1 (which would include the fix for #397). ;) |
|
@chastell the policy is that every contributor can merge if the PR looks good to him, so please go ahead. |
mvz
added a commit
that referenced
this pull request
Mar 3, 2015
Rename `CodeParser` to `TreeWalker`.
|
Argh, apologies, email management FUBAR resulting in me missing these replies. Thanks for merging and do feel free to roll 2.0.1 at will. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.