bug about sending bootstrap when configured of c-rp & c-bsr at same router

[zrs0923]

pim_proto.c L--3169:

int send_pim_cand_rp_adv(void)
{
u_int8 prefix_cnt;
u_int32 grp_mask;
pim_encod_grp_addr_t encod_grp_addr;
u_int8 *data_ptr;

if (!inet_valid_host(curr_bsr_address))
    return FALSE;  /* No BSR yet */

if (curr_bsr_address == my_bsr_address) {
    /* I am the BSR and have to include my own group_prefix stuff */
    prefix_cnt = *cand_rp_adv_message.prefix_cnt_ptr;
    if (prefix_cnt == 0) {
        /* The default 224.0.0.0 and masklen of 4 */
        MASKLEN_TO_MASK(ALL_MCAST_GROUPS_LENGTH, grp_mask);
        add_rp_grp_entry(&cand_rp_list, &grp_mask_list,
                         my_cand_rp_address, my_cand_rp_priority,
                         my_cand_rp_holdtime,
                         htonl(ALL_MCAST_GROUPS_ADDR),
                         my_bsr_hash_mask,
                         grp_mask, curr_bsr_fragment_tag);
        return TRUE;
    }

look carefully at the 7th and 8th arguments of function add_rp_grp_entry, seems they are at each others' place, otherwise the bootstrap message would have the group address of "0.0.0.0":
---------->add_rp_grp_entry(&cand_rp_list, &grp_mask_list,
my_cand_rp_address, my_cand_rp_priority,
my_cand_rp_holdtime,
htonl(ALL_MCAST_GROUPS_ADDR),
grp_mask,
my_bsr_hash_mask, curr_bsr_fragment_tag);

[troglobit]

Thanks for the heads up!

In the future it is preferable if you could attach a patch for the proposed fix, or a pull request.

[troglobit]

Fixed in c4b1c9f