Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(LiteFullNode): add DbLiteTest test case #5384

Closed
wants to merge 7 commits into from
Closed

test(LiteFullNode): add DbLiteTest test case #5384

wants to merge 7 commits into from

Conversation

forfreeday
Copy link
Contributor

@forfreeday forfreeday commented Jul 28, 2023 •
edited
Loading

What does this PR do?

  1. add DbLiteTest test case
  2. add test project dependencies: framework

Why are these changes required?
To improve test case execution efficiency and shorten test case execution time.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

test(LiteFullNode): add DbLiteTest test case
c2158ac 
1. add DbLiteTest test case
2. add test project dependencies: `framework`
@halibobo1205 halibobo1205 linked an issue Jul 31, 2023 that may be closed by this pull request
Moving LiteFullNodeTest test cases to plugins module #5380
Closed
@jwrct
Copy link
Contributor

jwrct commented Aug 2, 2023

Please solve the following error:

org.tron.plugins.DbLiteTest > testToolsWithLevelDBV2 FAILED
java.lang.RuntimeException: rename snapshot to output_lite_fn_LEVELDB_1690541222750/database failed
at org.tron.plugins.DbLiteTest.testTools(DbLiteTest.java:169)
  at org.tron.plugins.DbLiteTest.testToolsWithLevelDBV2(DbLiteTest.java:111)

@forfreeday
Copy link
Contributor Author

I'm checking this out.

@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 9, 2023
@halibobo1205
Copy link
Contributor

Is anyone working on this?

@halibobo1205
Copy link
Contributor

@forfreeday Need to resolve coverage degradation.

@forfreeday
Copy link
Contributor Author

@halibobo1205
I agree with your suggestion.

@forfreeday forfreeday closed this Sep 13, 2023
@halibobo1205 halibobo1205 removed this from the GreatVoyage-v4.7.3 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxo1shine xxo1shine xxo1shine approved these changes

@halibobo1205 halibobo1205 Awaiting requested review from halibobo1205

@jwrct jwrct Awaiting requested review from jwrct

Assignees

@forfreeday forfreeday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving LiteFullNodeTest test cases to plugins module
4 participants
@forfreeday @jwrct @halibobo1205 @xxo1shine