test(case): optimize test case #5456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2023 16:18
1. add AccountAssetStoreTest 2. add AssetIssueStoreTest 3. add AssetIssueV2StoreTest 4. add ContractStoreTest
5 tasks
lurais
reviewed
Aug 29, 2023
| @Before | ||
| public void init() { | ||
| accountAssetStore.put(ASSET_KEY, Longs.toByteArray(200L)); | ||
|
|
There was a problem hiding this comment.
This blank line does not affect the logic.
lurais
reviewed
Aug 29, 2023
| try { | ||
| ownerCapsule.addAssetV2(ByteArray.fromString(String.valueOf(id)), TOTAL_SUPPLY); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
It is possible not to throw this exception
There was a problem hiding this comment.
Shall it be throw out but not be caught ?
lurais
reviewed
Aug 29, 2023
| long assetKey2 = createAsset("testToken2"); | ||
| AccountCapsule accountCapsule = accountStore.get(ownerCapsule.getAddress().toByteArray()); | ||
|
|
||
| Map<String, Long> allAssets = accountAssetStore.getAllAssets(accountCapsule.getInstance()); |
There was a problem hiding this comment.
Assert the assets count in the map?
| assetIssueStore.put(assetIssueCapsule.createDbKey(), assetIssueCapsule); | ||
| } | ||
|
|
||
| private AssetIssueCapsule createAssetIssue(long id, String name) { |
There was a problem hiding this comment.
necessary, which is the ID in two different test cases
| AssetIssueContractOuterClass.AssetIssueContract.newBuilder() | ||
| .setName(ByteString.copyFrom(firstTokenId.getBytes())) | ||
| .build()); | ||
| assetIssueCapsule.setId(String.valueOf(2L)); |
There was a problem hiding this comment.
Will this id have conflict with other test cases?
|
|
||
| @Test | ||
| public void put() { | ||
| String firstTokenId = "efg"; |
There was a problem hiding this comment.
why use this name "firstTokenId"?
There was a problem hiding this comment.
This has nothing to do with code logic
| new ContractCapsule(contract.build())); | ||
| } | ||
|
|
||
| private SmartContractOuterClass.SmartContract.Builder createContract( |
There was a problem hiding this comment.
Why don't return a contractCapsule?
1. add DelegatedResourceStoreTest 2. add DelegationStoreTest 3. modify test case method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add several test cases to cover more code verification scenarios
Why are these changes required?
to improve test case coverage
This PR has been tested by:
Follow up
Extra details