test(db): add test for db #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurais
force-pushed
the
feature/add_cover_test
branch
from
366fc42 to
df8538f
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #5461 +/- ##
=============================================
+ Coverage 61.35% 61.50% +0.15%
- Complexity 9348 9379 +31
=============================================
Files 846 846
Lines 50211 50211
Branches 5583 5583
=============================================
+ Hits 30805 30884 +79
+ Misses 17002 16910 -92
- Partials 2404 2417 +13 see 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
forfreeday
reviewed
Aug 31, 2023
lurais
force-pushed
the
feature/add_cover_test
branch
from
df8538f to
c964848
Compare
5 tasks
forfreeday
reviewed
Sep 6, 2023
forfreeday
reviewed
Sep 7, 2023
forfreeday
reviewed
Sep 7, 2023
forfreeday
reviewed
Sep 7, 2023
forfreeday
reviewed
Sep 7, 2023
| Args.setParam( | ||
| new String[]{ | ||
| "--output-directory", dbPath, | ||
| "--history-balance-lookup" |
There was a problem hiding this comment.
You don't need --history-balance-lookup
lurais
force-pushed
the
feature/add_cover_test
branch
from
c964848 to
bc8e8df
Compare
halibobo1205
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add several test cases to cover more code verification scenarios
Why are these changes required?
improve test case coverage
This PR has been tested by:
Follow up
Extra details