Added pattern test cases for Alphabet D and E detectors #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
commented
Nov 11, 2024
| @@ -31,7 +30,7 @@ var _ detectors.Versioner = (*Scanner)(nil) | |||
| var ( | |||
| // Can use email or username for login. | |||
| usernamePat = regexp.MustCompile(`(?im)(?:user|usr|-u|id)\S{0,40}?[:=\s]{1,3}[ '"=]?([a-zA-Z0-9]{4,40})\b`) | |||
| emailPat = regexp.MustCompile(`(` + common.EmailPattern + `)`) | |||
| emailPat = regexp.MustCompile(common.EmailPattern) | |||
There was a problem hiding this comment.
Because the capturing group is already added to the common Email Pattern.
kashifkhan0771
changed the title
zricethezav
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR added Pattern test cases for detectors starting with Alphabet D and E. It also separate the integration test cases for those detectors.
Tests Output 🚀:
Checklist:
make test-community)?make lintthis requires golangci-lint)?