added pattern test cases for F, G and H alphabet detectors #3590
Conversation
kashifkhan0771
force-pushed
the
tests/pattern-test-cases-f-to-h
branch
from
64adcd0 to
4e20fb9
Compare
| @@ -20,6 +19,9 @@ type Scanner struct { | |||
|
|
|||
| // Ensure the Scanner satisfies the interfaces at compile time. | |||
| var _ detectors.Detector = (*Scanner)(nil) | |||
| var _ detectors.EndpointCustomizer = (*Scanner)(nil) | |||
There was a problem hiding this comment.
Added this because a engine test case was failing due to missing method in this detector.
There was a problem hiding this comment.
hey @kashifkhan0771 would you mind double checking some comments here around this. I might've misunderstood Miccah's comment and tried to fix this issue with: #3592
Not sure if I made it worse 😓
There was a problem hiding this comment.
Your fix is definitely the right approach! I had the same thought that we are not actually using endpoint customizer in this detector. I didn't remove it though, because I was worried it might accidentally break something. 🫢
There was a problem hiding this comment.
Thank you for double checking. ❤️
There was a problem hiding this comment.
Done 🚀 Updated with your changes from main.
kashifkhan0771
changed the title
Description:
This PR add the pattern test cases for detectors starting with alphabet
ftoh. It also separate the integration test cases for those detectors.Test Output:
Checklist:
make test-community)?make lintthis requires golangci-lint)?