Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AzureAD/microsoft-authentication-library-for-go #3642

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Nov 21, 2024

Description:

This library is no longer used for the Azure sp detector. The only remaining place was for an errors.Is function call, which is more than likely a mistake by automatic import.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested review from a team as code owners November 21, 2024 00:25
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always fan of removing dependencies 🎉 Thanks.

@ahrav ahrav merged commit b215853 into trufflesecurity:main Nov 21, 2024
12 of 13 checks passed
@rgmz rgmz deleted the chore/remove-unuseddep branch November 21, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants