Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - add pkg level doc #3684

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[chore] - add pkg level doc #3684

merged 1 commit into from
Dec 2, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 26, 2024

Description:

This PR adds a pkg level comment for iobuf.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review November 26, 2024 21:57
@ahrav ahrav requested review from a team as code owners November 26, 2024 21:57
@ahrav ahrav requested review from a team November 26, 2024 21:57
zricethezav
zricethezav approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@zricethezav zricethezav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@zricethezav zricethezav merged commit 7e60ca3 into main Dec 2, 2024
13 checks passed
@zricethezav zricethezav deleted the chore-add-pkg-doc branch December 2, 2024 19:09
@blsaccess blsaccess mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrav @rosecodym @zricethezav