Reinstated Postman body scanning #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Feb 12, 2025
pkg/sources/postman/postman.go
Outdated
| s.scanData(ctx, chunksChan, s.formatAndInjectKeywords(s.buildSubstitueSet(m, data)), m) | ||
| m.LocationType = source_metadatapb.PostmanLocationType_UNKNOWN_POSTMAN | ||
| default: | ||
| break |
There was a problem hiding this comment.
It looks like it was in the original code that was removed, but it also seems unnecessary there. @casey-tran can we take this out?
rosecodym
approved these changes
Feb 12, 2025
pkg/sources/postman/postman.go
Outdated
| s.scanData(ctx, chunksChan, s.formatAndInjectKeywords(s.buildSubstitueSet(m, data)), m) | ||
| m.LocationType = source_metadatapb.PostmanLocationType_UNKNOWN_POSTMAN | ||
| default: | ||
| break |
There was a problem hiding this comment.
It looks like it was in the original code that was removed, but it also seems unnecessary there. @casey-tran can we take this out?
pkg/sources/postman/postman.go
Outdated
| m.LocationType = source_metadatapb.PostmanLocationType_REQUEST_BODY_URL_ENCODED | ||
| s.scanVariableData(ctx, chunksChan, m, vars) | ||
| m.LocationType = source_metadatapb.PostmanLocationType_UNKNOWN_POSTMAN | ||
| case "raw", "graphql": |
There was a problem hiding this comment.
Do you know why these cases are collapsed into one instead of being split out like formdata and urlencoded?
There was a problem hiding this comment.
That probably originated with me and definitely doesn't make sense. I think they should split out.
joeleonjr
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Gave Postman sources the ability to scan request bodies again. Gave the function a more specific name to differentiate from scanning response bodies.
Reinstating the code removed here.
Checklist:
make test-community)?make lintthis requires golangci-lint)?