Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Fixed the Return of the GCP Detector #3905

Merged
merged 3 commits into from
Feb 12, 2025
Merged

[Update] Fixed the Return of the GCP Detector #3905

merged 3 commits into from
Feb 12, 2025

Conversation

nabeelalam
Copy link
Contributor

@nabeelalam nabeelalam commented Feb 12, 2025 •
edited
Loading

Description:

Updated gcp.go GCP detector. Previously it would not return any results even if credentials were matched but were unverified due to auth errors.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@nabeelalam nabeelalam marked this pull request as ready for review February 12, 2025 11:41
@nabeelalam nabeelalam requested a review from a team as a code owner February 12, 2025 11:41
@zricethezav zricethezav merged commit ec42f44 into trufflesecurity:main Feb 12, 2025
13 checks passed
@blsaccess blsaccess mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabeelalam @zricethezav