Remove duplicate github.com/golang-jwt/jwt dependency
#3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our codebase currently uses v3, v4, and v5 versions of the `github.com/golang-jwt/jwt` dependency. To maintain consistency, we should standardize on using only the latest v5 version. Signed-off-by: Eng Zer Jun <[email protected]>
ahrav
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our codebase currently uses versions v3, v4, and v5 of the
github.com/golang-jwt/jwtdependency. To maintain consistency, we should standardize on using only the latest v5 version.trufflehog/go.mod
Lines 56 to 58 in 6f1e918
From the MIGRATION GUIDE:
github.com/golang-jwt/jwt/v4is backward compatible with v3jackfan.us.kg/golang-jwt/jwt/v5introduces some core changes, but fortunately, the interfaces and public APIs we use remain unaffected.Checklist:
make test-community)?make lintthis requires golangci-lint)?