Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Implement cpp-ethereum's test RPC API [WIP] #264

Closed
wants to merge 1 commit into from
Closed

Implement cpp-ethereum's test RPC API [WIP] #264

wants to merge 1 commit into from

Conversation

axic
Copy link
Contributor

@axic axic commented Feb 15, 2017

This API is used by Solidity's soltest (the testing architecture) and https://github.com/ethereum/ethereum-console

Also see: ethereum/interfaces#4


var test_blocks = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically this API has the ability to roll back to any previous block. That would mean to keep a snapshot of every block during the generic mine method.

Object.keys(chain.accounts).forEach(function(address) {
var account = self.state.accounts[address];
if (account) {
// FIME: support changing balance of associated account
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be implemented.

@tinybike
Copy link

@axic I'm curious, is cpp-ethereum still under active development / is it a client that is reasonably widely used? All I hear about these days is geth and parity...

@axic
Copy link
Contributor Author

axic commented Feb 15, 2017

@tinybike it is still actively maintained, but I don't think it is widely used

@benjamincburns
Copy link
Contributor

@axic how do you rate this suite against something like karalabe/hive? Would it be worth the effort to move this sucker over to trufflesuite/ganache-core, or would it be better if we concentrated our efforts on hive? I'm somewhat inclined to think the latter.

Closing either way.

@axic
Copy link
Contributor Author

axic commented Oct 23, 2017

This has no relation to hive, it has a different purpose.

@benjamincburns
Copy link
Contributor

@axic sorry, I misunderstood the basis for this PR... Rereading, the real question I should've asked is how relevant this still is today? Do the solidity unit tests still rely on these RPC calls in cpp-ethereum?

@tcoulter said that you guys are testing against testrpc already today (since we broke the solidity tests last month)? How is this accomplished? Does this change make that task easier?

@axic
Copy link
Contributor Author

axic commented Jan 28, 2018

Rereading, the real question I should've asked is how relevant this still is today? Do the solidity unit tests still rely on these RPC calls in cpp-ethereum?

Yes.

said that you guys are testing against testrpc already today

No. We are running Zeppelin's tests, which uses truffle internally. But that only runs Zeppelin's tests cases and not Solidity cases (~ 600 hundred tests).

Does this change make that task easier?

Has no relation to Zeppelin.

@davidmurdoch davidmurdoch deleted the test-api branch April 9, 2019 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants