-
Notifications
You must be signed in to change notification settings - Fork 695
Implement cpp-ethereum's test RPC API [WIP] #264
Conversation
|
||
var test_blocks = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically this API has the ability to roll back to any previous block. That would mean to keep a snapshot of every block during the generic mine method.
Object.keys(chain.accounts).forEach(function(address) { | ||
var account = self.state.accounts[address]; | ||
if (account) { | ||
// FIME: support changing balance of associated account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be implemented.
@axic I'm curious, is cpp-ethereum still under active development / is it a client that is reasonably widely used? All I hear about these days is geth and parity... |
@tinybike it is still actively maintained, but I don't think it is widely used |
@axic how do you rate this suite against something like karalabe/hive? Would it be worth the effort to move this sucker over to trufflesuite/ganache-core, or would it be better if we concentrated our efforts on Closing either way. |
This has no relation to hive, it has a different purpose. |
@axic sorry, I misunderstood the basis for this PR... Rereading, the real question I should've asked is how relevant this still is today? Do the solidity unit tests still rely on these RPC calls in cpp-ethereum? @tcoulter said that you guys are testing against testrpc already today (since we broke the solidity tests last month)? How is this accomplished? Does this change make that task easier? |
Yes.
No. We are running Zeppelin's tests, which uses truffle internally. But that only runs Zeppelin's tests cases and not Solidity cases (~ 600 hundred tests).
Has no relation to Zeppelin. |
This API is used by Solidity's soltest (the testing architecture) and https://github.com/ethereum/ethereum-console
Also see: ethereum/interfaces#4