This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Feature/request library #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch tests fail on work machine with
After this PR Unbox 3 passing (1s) |
gnidan
suggested changes
Oct 5, 2017
lib/utils/unbox.js
Outdated
| }; | ||
| var req = https.request(options, function(r) { | ||
| request(options, function(error, r) { |
There was a problem hiding this comment.
@micahriggan actually one comment - would you mind adding a check for error now that it's a new arg?
There was a problem hiding this comment.
~ if (error) {
+ return reject(new Error("Error making request. Please check the format of the requested resource: " + options.uri));
+ } else if (r.statusCode == 404) {
Would something like this work?
gnidan
approved these changes
Oct 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native nodejs https.request method doesn't follow proxy environment variables.
This is referenced by nodejs/node#8381
The request library does support these environment variables.
These environment variables are commonly used at the corporation I work for, so not supporting them is a barrier to entry for many corporate developers.
This should close
trufflesuite/truffle-init#1