This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Merge develop -> master for Truffle 4 release #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge `master` into `develop`
Ignore yarn.lock _for now_ until we standardize our development process around it, or choose a different method of managing our packages and repositories.
Previous code that fixed file paths on Windows broke package imports for everybody. :(
I came here to handle the changes to the schema, namely that `updated_at` is now `updatedAt`. This is an easy change. While I was here decided to also fix truffle/#444 and truffle/#368. This was because the profiler was only comparing the modified times of files within the contracts directory. The new schema changes — specifically the inclusion of `sourcePath` — lets us check whether everything has been updated, no matter where it lives. This new method works backwards, combining all the files passed into the profiler with all the contract artifacts already compiled. After creating a list of all files necessary (again, the files requested to be compiled as well as artifacts and their associated source paths), it checks the modified times of all the source files against the artifact’s modified time, creating a list of which new files have been updated. Note that one source file may have many artifact files (multiple contracts per file). There’s a rare edge case where if a file lives outside of the contracts directory and is deleted, but has already been compiled once, the compiler won’t try to compile everything again (thus, it won’t error, even though the dependent file was removed). This is because the contract artifact exists but the source file does not. In this case we choose *not* to error because if we did, it would cause all old contract artifacts to be showstoppers of compilation, and it’s not our business to delete old contract artifacts (users may want to keep them, for some reason). So for now, we’re not going to error in this case, and we’re going to leave it up to the user to manage their excess artifacts.
Fix typo compiliation > compilation
Remove solidity parser.
Fix regex for import statement
Upgrade solc to v0.4.17
Save os paths
Include compiler information in contract definition
Upgrade solc to v0.4.18
Load solc module in lazy fashion. Saves up to 2s on tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trufflesuite/truffle#646