This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Order ABI correctly in multi-contract files #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
changed the title
1 task
cgewecke
commented
Mar 6, 2018
|
|
||
| it("orders the complex ABI", function(){ | ||
| var expectedOrder = ['LogB', 'LogA', 'LogD', 'LogC', 'theFirst', 'second', 'andThird']; | ||
| var sources = {}; |
There was a problem hiding this comment.
This is a little confusing. . . i.e not sure events are contributing to clarity of this test.
gnidan
approved these changes
Mar 6, 2018
| // AST can have multiple contract definitions, make sure we have the | ||
| // one that matches our contract | ||
| if (definition.name !== "ContractDefinition" || | ||
| definition.attributes.name !== contract.contract_name){ |
There was a problem hiding this comment.
Maybe contract.contractName cause snake case is deprecated in truffle-contract-schema
There was a problem hiding this comment.
Nice catch and agree but will revisit in a separate PR because contract_name all over the place in this file and need to investigate the full implications of upgrading here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses truffle 812
While processing the AST to identify
ContractDefinitions, we have to make sure a given definition node matches the contract name. Solc produces an AST that lays out all the contracts in a file adjacently but only one of these belongs to the contract in question.Re-factored the tests so that we have examples of single contract files, multi-contract files and inheritance from an imported file.