This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Merge develop -> master for Truffle 4 release #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add runtimeBytecode -> deployedBytecode normalization - Ensure deployedBytecode starts with 0x in generated output
- Use separate methods for different sources (solc, abstraction, regular opts) - Make `networks`, `address`, etc. (properties related to instance or truffle specifically) explicitly not a part of normalization process - Move code around in `generateObject` to ensure truffle-option copying happens (now that it's gone from normalize) - Switch to camelCase for fields in schema - Add initial test for solc standard output - Remove `x-` check for `normalizeInput`, as that's no longer part of that.
- Use property compatibility / data transformation mapping to identify where data should come from in a uniform manner.
- Drop notion of "additional sources" - define properties to list sources explicitly including their canonical name, or default to source only canonical name when `"sources":` is omitted - Allow string values for sources in addition to functions. For string values, assume possible chain operation (e.g. "evm.bytecode.object") and split/chain accordingly
- Change `objectable` (whatever that means) to `objDirty` - Move `properties` to the top and give it a docstring - Move getter/chain combinators lower, also document
Improve `solc` compatibility
- Rename schema_version import to pkgVersion - Inline copyCustomOptions (not needed separately) - Eliminate contractName default
Formalize schema, standardize on normalization process, and improve solc support
- Pull out name/type as own definitions. - Build regex for valid ABI types - Add title - Ensure ABI items don't match more than one event/function schema
- ABI names can be blank in some cases - Bytecode should not stipulate anything about the 38 characters after `__` in refs
Ignore yarn.lock _for now_ until we standardize our development process around it, or choose a different method of managing our packages and repositories.
Add schema docs for contract/network objects
Define schemas for ABI and Network Objects
Fix ABI spec for latest `solc`
Add compiler info to spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trufflesuite/truffle#646